-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to specify a lifecycle or remove the hardcoded value during build #1379
Comments
I removed the lifecycle and rebuilt the CLI locally and it was able to successfully build my function. |
/kind enhancement |
/assign |
@grafvonb we discussed this in the WG call this week, and I think the immediate fix is to add the vmware builders to the list of trusted builders in Lines 37 to 41 in ea79cf0
That will address the immediate issue (along with this being a partial fix: #1403). The longer term solution, I believe, will be to allow for global configuration of trusted builders using |
@lance ok, got it, since it got an So please let me when the long term solution is "stable" 😄 (do we have a way here to recognize that?). Thx. |
@grafvonb happy to iterate on that long-term idea here (or in GH Discussions). Starting here for now and we can move it someplace else if we feel it needs wider visibility or a better format than just a bunch of comments. I could see a /cc @knative/func-reviewers @knative/func-writers @knative/functions-wg-leads |
@lance Please also add |
#Problem
In an attempt to use
ghcr.io/vmware-tanzu/function-buildpacks-for-knative/functions-builder:0.2.0
to build a function (generated from some templates) using thefunc
CLI. I ran into the following fromfunc build -v
:I noticed that
quay.io/boson/lifecycle:0.13.2
lifecycle is hardcoded into the pack options. However, the builder I was trying to use already specifies what lifecycle it needs. This may have caused a conflict between them.Proposal:
The text was updated successfully, but these errors were encountered: