Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In multimodule Golang project upgrade-deps script will float current project references #264

Closed
cardil opened this issue Jan 31, 2023 · 1 comment · Fixed by knative/test-infra#3696
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cardil
Copy link
Contributor

cardil commented Jan 31, 2023

In projects that utilize Go workspaces, we can have the following situation:

// in build/go.mod
module knative.dev/kn-plugin-event/build

require knative.dev/kn-plugin-event v0.0.0

replace knative.dev/kn-plugin-event => ../

When running hack/update-deps.sh --upgrade --release 1.9 that mock version v0.0.0 gets replaced by current version string, like v0.34.1-0.20230130203928-59adc6bd3cf7.

This prevents doing a release because the releaseability job creates a PR to align deps (see example: knative-extensions/kn-plugin-event#261). Even after merger of such PR, another PR is created (see: knative-extensions/kn-plugin-event#262). This prevents the release.

/kind bug

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 31, 2023
@cardil
Copy link
Contributor Author

cardil commented Jan 31, 2023

Probably, the buoy logic needs to be adjusted to exclude the current project from floating deps.

hack/library.sh

Line 705 in c7cfcb0

local buoyArgs=(--release ${RELEASE} --domain ${DOMAIN})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant