Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to generate kustomize base files from helm chart #1546

Closed
hhk7734 opened this issue Aug 29, 2023 · 3 comments · May be fixed by #1634
Closed

change to generate kustomize base files from helm chart #1546

hhk7734 opened this issue Aug 29, 2023 · 3 comments · May be fixed by #1634
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@hhk7734
Copy link
Member

hhk7734 commented Aug 29, 2023

Problem
The current chart is generated by hack/generate-helm.sh, which makes it difficult to modify the Helm template.

Therefore, I propose generating the base files used for Kustomize from the chart, in the opposite way of the current method.

Persona:
System Operator

Exit Criteria
Pass existing CI tests using helm chart and kustomize

Time Estimate (optional):
1 developer, 1~2 days

After changes

./
├── config/
│   ├── charts/
│   │   ├── knative-operator/
│   │   │   ├── Chart.yaml
│   │   │   ├── templates/
│   │   │   │   ├── crd/
│   │   │   │   │   └── bases/
│   │   │   │   │       ├── operator.knative.dev_knativeeventings.yaml
│   │   │   │   │       └── operator.knative.dev_knativeservings.yaml
│   │   │   │   ├── manager/
│   │   │   │   │   ├── config-logging-configmap.yaml
│   │   │   │   │   ├── config-observability-configmap.yaml
│   │   │   │   │   └── operator.yaml
│   │   │   │   ├── rbac/
│   │   │   │   │   ├── clusterrole_aggregated.yaml
│   │   │   │   │   ├── clusterrole_aggregated_binding.yaml
│   │   │   │   │   ├── fake_clusterrole_aggregated_binding.yaml
│   │   │   │   │   ├── fake_service_account.yaml
│   │   │   │   │   ├── role.yaml
│   │   │   │   │   ├── role_binding.yaml
│   │   │   │   │   ├── service_account.yaml
│   │   │   │   │   ├── webhook_role.yaml
│   │   │   │   │   ├── webhook_role_binding.yaml
│   │   │   │   │   └── webhook_service_account.yaml
│   │   │   │   ├──  webhook/
│   │   │   │   │   ├── webhook-secret.yaml
│   │   │   │   │   ├── webhook-service.yaml
│   │   │   │   │   └── webhook.yaml
│   │   │   │   └──  ...
│   │   │   └── values.yaml
│   │   └──  ...
│   ├── crd/
│   │   └──  ...
│   ├── manager/
│   │   └──  ...
│   ├── rbac/
│   │   └──  ...
│   ├── webhook/
│   │   └──  ...
│   └──  ...
├── hack/
│   ├── generate-kustomize.sh
│   └──  ...
└──  ...
@houshengbo
Copy link
Contributor

houshengbo commented Sep 20, 2023

@hhk7734 Knative operator now has to publish the artifacts in three ways: general yaml on the release page, operatorhub and the helm charts. The current structure is crucial for https://github.com/knative/operator/blob/main/hack/generate-bundle.sh, which is to generate the bundle to publish in operatorhub.
I am wondering if you can take this into account as well to optimize the structure of the yamls.

@hhk7734
Copy link
Member Author

hhk7734 commented Oct 6, 2023

I expect the generate-bundle.sh script to work just fine, since I'm aiming to create config/** from config/charts as is. I'll work on it as soon as I have time and make a PR, so please review again then.

Copy link

github-actions bot commented Jan 5, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2024
@github-actions github-actions bot closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants