Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller Package Test is Flakey #65

Closed
dprotaso opened this issue Sep 10, 2018 · 1 comment
Closed

Controller Package Test is Flakey #65

dprotaso opened this issue Sep 10, 2018 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@dprotaso
Copy link
Member

Expected Behaviour

Expect running the unit test TestEnqueues to not fail

Actual Behaviour

TestEnqueues did fail here:

I0910 19:38:25.078] --- FAIL: TestEnqueues (0.11s)
I0910 19:38:25.078]     --- PASS: TestEnqueues/do_nothing (0.01s)
I0910 19:38:25.078]     --- PASS: TestEnqueues/enqueue_key (0.01s)
I0910 19:38:25.078]     --- FAIL: TestEnqueues/enqueue_duplicate_key (0.01s)
I0910 19:38:25.079]     	controller_test.go:244: unexpected queue (-want +got): {[]string}:
I0910 19:38:25.079]     			-: []string{"foo/bar"}
I0910 19:38:25.079]     			+: []string(nil)
I0910 19:38:25.079]     --- PASS: TestEnqueues/enqueue_different_keys (0.01s)
I0910 19:38:25.079]     --- PASS: TestEnqueues/enqueue_resource (0.01s)
I0910 19:38:25.079]     --- PASS: TestEnqueues/enqueue_bad_resource (0.01s)
I0910 19:38:25.079]     --- PASS: TestEnqueues/enqueue_controller_of_bad_resource (0.01s)
I0910 19:38:25.079]     --- PASS: TestEnqueues/enqueue_controller_of_resource_without_owner (0.01s)
I0910 19:38:25.079]     --- PASS: TestEnqueues/enqueue_controller_of_resource_with_owner (0.01s)

Steps to Reproduce the Problem

I'm actually unable to reproduce it locally using go version go1.10.3 darwin/amd64

go test -run TestEnqueues -count 1000 > out.txt
@knative-prow-robot knative-prow-robot added kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 10, 2018
@dprotaso
Copy link
Member Author

closing dupe of #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dprotaso @knative-prow-robot