-
Notifications
You must be signed in to change notification settings - Fork 1.1k
/
revision_defaults.go
184 lines (159 loc) · 5.86 KB
/
revision_defaults.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
/*
Copyright 2019 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package v1
import (
"context"
"strconv"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
"k8s.io/apimachinery/pkg/util/sets"
"knative.dev/pkg/apis"
"knative.dev/pkg/kmeta"
"knative.dev/pkg/ptr"
"knative.dev/serving/pkg/apis/config"
)
// SetDefaults implements apis.Defaultable
func (r *Revision) SetDefaults(ctx context.Context) {
// SetDefaults may update revision spec which is immutable.
// See: https://github.com/knative/serving/issues/8128 for details.
if apis.IsInUpdate(ctx) {
return
}
r.Spec.SetDefaults(apis.WithinSpec(ctx))
}
// SetDefaults implements apis.Defaultable
func (rts *RevisionTemplateSpec) SetDefaults(ctx context.Context) {
rts.Spec.SetDefaults(apis.WithinSpec(ctx))
}
// SetDefaults implements apis.Defaultable
func (rs *RevisionSpec) SetDefaults(ctx context.Context) {
cfg := config.FromContextOrDefaults(ctx)
// Default TimeoutSeconds based on our configmap.
if rs.TimeoutSeconds == nil || *rs.TimeoutSeconds == 0 {
rs.TimeoutSeconds = ptr.Int64(cfg.Defaults.RevisionTimeoutSeconds)
}
// Default ContainerConcurrency based on our configmap.
if rs.ContainerConcurrency == nil {
rs.ContainerConcurrency = ptr.Int64(cfg.Defaults.ContainerConcurrency)
}
// Avoid clashes with user-supplied names when generating defaults.
containerNames := make(sets.String, len(rs.PodSpec.Containers)+len(rs.PodSpec.InitContainers))
for idx := range rs.PodSpec.Containers {
containerNames.Insert(rs.PodSpec.Containers[idx].Name)
}
for idx := range rs.PodSpec.InitContainers {
containerNames.Insert(rs.PodSpec.InitContainers[idx].Name)
}
defaultUserContainerName := cfg.Defaults.UserContainerName(ctx)
applyDefaultContainerNames(rs.PodSpec.Containers, containerNames, defaultUserContainerName)
defaultInitContainerName := cfg.Defaults.InitContainerName(ctx)
applyDefaultContainerNames(rs.PodSpec.InitContainers, containerNames, defaultInitContainerName)
for idx := range rs.PodSpec.Containers {
rs.applyDefault(ctx, &rs.PodSpec.Containers[idx], cfg)
}
}
func (rs *RevisionSpec) applyDefault(ctx context.Context, container *corev1.Container, cfg *config.Config) {
if container.Resources.Requests == nil {
container.Resources.Requests = corev1.ResourceList{}
}
if container.Resources.Limits == nil {
container.Resources.Limits = corev1.ResourceList{}
}
for _, r := range []struct {
Name corev1.ResourceName
Request *resource.Quantity
Limit *resource.Quantity
}{{
Name: corev1.ResourceCPU,
Request: cfg.Defaults.RevisionCPURequest,
Limit: cfg.Defaults.RevisionCPULimit,
}, {
Name: corev1.ResourceMemory,
Request: cfg.Defaults.RevisionMemoryRequest,
Limit: cfg.Defaults.RevisionMemoryLimit,
}, {
Name: corev1.ResourceEphemeralStorage,
Request: cfg.Defaults.RevisionEphemeralStorageRequest,
Limit: cfg.Defaults.RevisionEphemeralStorageLimit,
}} {
if _, ok := container.Resources.Requests[r.Name]; !ok && r.Request != nil {
container.Resources.Requests[r.Name] = *r.Request
}
if _, ok := container.Resources.Limits[r.Name]; !ok && r.Limit != nil {
container.Resources.Limits[r.Name] = *r.Limit
}
}
// If there are multiple containers then default probes will be applied to the container where user specified PORT
// default probes will not be applied for non serving containers
if len(rs.PodSpec.Containers) == 1 || len(container.Ports) != 0 {
rs.applyProbes(container)
}
if rs.PodSpec.EnableServiceLinks == nil && apis.IsInCreate(ctx) {
rs.PodSpec.EnableServiceLinks = cfg.Defaults.EnableServiceLinks
}
vNames := make(sets.String)
for _, v := range rs.PodSpec.Volumes {
if v.EmptyDir != nil || v.PersistentVolumeClaim != nil {
vNames.Insert(v.Name)
}
}
vms := container.VolumeMounts
for i := range vms {
if !vNames.Has(vms[i].Name) {
vms[i].ReadOnly = true
}
}
}
func (*RevisionSpec) applyProbes(container *corev1.Container) {
if container.ReadinessProbe == nil {
container.ReadinessProbe = &corev1.Probe{}
}
if container.ReadinessProbe.TCPSocket == nil &&
container.ReadinessProbe.HTTPGet == nil &&
container.ReadinessProbe.Exec == nil {
container.ReadinessProbe.TCPSocket = &corev1.TCPSocketAction{}
}
if container.ReadinessProbe.SuccessThreshold == 0 {
container.ReadinessProbe.SuccessThreshold = 1
}
// Apply k8s defaults when ReadinessProbe.PeriodSeconds property is set
if container.ReadinessProbe.PeriodSeconds != 0 {
if container.ReadinessProbe.FailureThreshold == 0 {
container.ReadinessProbe.FailureThreshold = 3
}
if container.ReadinessProbe.TimeoutSeconds == 0 {
container.ReadinessProbe.TimeoutSeconds = 1
}
}
}
func applyDefaultContainerNames(containers []corev1.Container, containerNames sets.String, defaultContainerName string) {
// Default container name based on ContainerNameFromTemplate value from configmap.
// In multi-container or init-container mode, add a numeric suffix, avoiding clashes with user-supplied names.
nextSuffix := 0
for idx := range containers {
if containers[idx].Name == "" {
name := defaultContainerName
if len(containers) > 1 || containerNames.Has(name) {
for {
name = kmeta.ChildName(defaultContainerName, "-"+strconv.Itoa(nextSuffix))
nextSuffix++
// Continue until we get a name that doesn't clash with a user-supplied name.
if !containerNames.Has(name) {
break
}
}
}
containers[idx].Name = name
}
}
}