Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing host header with port #12974

Merged
merged 2 commits into from May 30, 2022
Merged

Support parsing host header with port #12974

merged 2 commits into from May 30, 2022

Conversation

Mgla96
Copy link
Contributor

@Mgla96 Mgla96 commented May 29, 2022

Fixes #12973

Proposed Changes

  • If a request with 'Host' header or host name explicitly contains a port, the activator would fail to parse the name and namespace from the request.

Release Note

Support for parsing name and namespace in activator from a request when 'Host' header or host name contains a port

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 29, 2022
@knative-prow
Copy link

knative-prow bot commented May 29, 2022

Hi @Mgla96. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/autoscale area/networking labels May 29, 2022
@Mgla96 Mgla96 changed the title 12973 support parsing host header with port support parsing host header with port May 29, 2022
@Mgla96 Mgla96 changed the title support parsing host header with port Support parsing host header with port May 29, 2022
@psschwei
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #12974 (215458c) into main (33dbc31) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12974      +/-   ##
==========================================
- Coverage   86.97%   86.96%   -0.02%     
==========================================
  Files         197      197              
  Lines       14439    14439              
==========================================
- Hits        12559    12557       -2     
- Misses       1583     1585       +2     
  Partials      297      297              
Impacted Files Coverage Δ
pkg/activator/handler/context_handler.go 97.29% <100.00%> (ø)
pkg/autoscaler/statserver/server.go 77.77% <0.00%> (-1.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dbc31...215458c. Read the comment docs.

@nader-ziada
Copy link
Member

thanks @Mgla96

lgtm

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@knative-prow
Copy link

knative-prow bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Mgla96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@knative-prow knative-prow bot merged commit ca6a190 into knative:main May 30, 2022
@Mgla96 Mgla96 deleted the 12973-support-parsing-host-header-with-port branch May 30, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support parsing Host header/name in request when it contains a port
4 participants