Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the capability for perf tests to store their results in an influxdb #13192

Merged
merged 13 commits into from Sep 14, 2022
Merged

Add the capability for perf tests to store their results in an influxdb #13192

merged 13 commits into from Sep 14, 2022

Conversation

nader-ziada
Copy link
Member

Fixes #

Proposed Changes

  • Add perf tests results to a community hosted influxdb

Release Note

Save data from perf tests to create a dashboard.

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022 •
edited

Codecov Report

Base: 86.48% // Head: 86.50% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (5acc806) compared to base (43c7a5c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13192      +/-   ##
==========================================
+ Coverage   86.48%   86.50%   +0.02%     
==========================================
  Files         196      196              
  Lines       14544    14544              
==========================================
+ Hits        12578    12582       +4     
+ Misses       1666     1664       -2     
+ Partials      300      298       -2
Impacted Files Coverage Δ
pkg/activator/net/revision_backends.go 92.19% <0.00%> (-0.58%) ⬇️
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️
pkg/autoscaler/statforwarder/leases.go 73.95% <0.00%> (+1.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nader-ziada nader-ziada force-pushed the influx branch 2 times, most recently from 2cb6217 to ed84f9f Compare August 5, 2022 19:21
@nader-ziada
Copy link
Member Author

/test ls

@knative-prow
Copy link

knative-prow bot commented Aug 5, 2022

@nader-ziada: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-tests_serving_main
  • /test contour-latest_serving_main
  • /test contour-tls_serving_main
  • /test gateway-api-latest_serving_main
  • /test istio-latest-no-mesh-tls_serving_main
  • /test istio-latest-no-mesh_serving_main
  • /test kourier-stable-tls_serving_main
  • /test kourier-stable_serving_main
  • /test unit-tests_serving_main
  • /test upgrade-tests_serving_main

The following commands are available to trigger optional jobs:

  • /test https_serving_main
  • /test istio-latest-mesh-short_serving_main
  • /test istio-latest-mesh-tls_serving_main
  • /test istio-latest-mesh_serving_main
  • /test performance-tests-kperf_serving_main
  • /test performance-tests-mako_serving_main

Use /test all to run the following jobs that were automatically triggered:

  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • unit-tests_serving_main
  • upgrade-tests_serving_main

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

2 similar comments
@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

1 similar comment
@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada nader-ziada mentioned this pull request Aug 11, 2022
Closed
4 tasks
@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

4 similar comments
@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

@nader-ziada
Copy link
Member Author

/test performance-tests-mako_serving_main

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 14, 2022
View reviewed changes
test/performance/influx_client.go
SetUseGZip(true).
SetBatchSize(20).
//nolint:gosec // We explicitly don't need to check certs here since this is test code.
SetTLSConfig(&tls.Config{InsecureSkipVerify: true}))

Check failure

Code scanning / CodeQL

Disabled TLS certificate check

InsecureSkipVerify should not be used in production code.
@nader-ziada
Copy link
Member Author

@psschwei made the changes

psschwei
psschwei reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@nader-ziada
Copy link
Member Author

@dprotaso you will have to dismiss the alert again for this to merge

@psschwei
Copy link
Contributor

There's also a merge conflict in go.sum (looks like there was a race with the update deps job)

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2022
@nader-ziada
Copy link
Member Author

are detected. LGTM label has been removed

fixed the rebase conflict, but it removed your lgtm

psschwei
psschwei reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@knative-prow knative-prow bot merged commit c832f35 into knative:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nader-ziada @dprotaso @psschwei @knative-prow-robot