Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide HTTPS for cluster.local domains #13472

Closed
doddatpivotal opened this issue Nov 15, 2022 · 6 comments
Closed

Provide HTTPS for cluster.local domains #13472

doddatpivotal opened this issue Nov 15, 2022 · 6 comments
Assignees
Labels
area/networking kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@doddatpivotal
Copy link

doddatpivotal commented Nov 15, 2022

/area networking
/kind feature

Expected Behavior

I would like to have an https based internal service? I'm currently configured for HTTPS for standard external service, but as soon as I put the internal service annotation on my kservice, the exposed service turns to HTTP.

Additional Info

In my particular use case, I have a 3rd party controller on my cluster that can be configured to call specific endpoints for processing. This controller exclusively uses an HTTPS client. I built a Kservice for this controller to call. However, even though I have no use for my service to be exposed outside the cluster, I had to configure it that way in order to have the KService be exposed as HTTPS.

My current cluster issuer configured with Knative serving and auto-tls would not work with the FQDN's for the custom service. I would expect the need to configure an alternative clusterissuer for internal service use.

@knative-prow knative-prow bot added area/networking kind/feature Well-understood/specified features, ready for coding. labels Nov 15, 2022
@evankanderson
Copy link
Member

Related to the Knative Eventing TLS proposal -- ideally, the same mechanism could be used for both this feature and for Eventing to reach the endpoint via TLS.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2023
@ReToCode
Copy link
Member

Might be handled in #11906.

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2023
@amarflybot
Copy link
Contributor

Will this also allow TLS on cluster-local to communicate between two knative service pods?
Currently certificates are not provided when we use cluster-local, because of https://github.com/knative/serving/blob/main/pkg/reconciler/route/route.go#L195-L200

@ReToCode
Copy link
Member

Yes, this would be the intention.

@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label Feb 23, 2023
@ReToCode ReToCode self-assigned this May 15, 2023
@dprotaso dprotaso changed the title Allow for HTTPS on Internal Routes Feature-Request: Provide HTTPS for cluster.local domains Sep 14, 2023
@dprotaso dprotaso changed the title Feature-Request: Provide HTTPS for cluster.local domains Provide HTTPS for cluster.local domains Sep 14, 2023
@ReToCode ReToCode added this to the v1.14.0 milestone Mar 11, 2024
@ReToCode
Copy link
Member

1.14 will contain an experimental version of this feature. Docs PR here: knative/docs#5804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
Development

No branches or pull requests

4 participants