Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serving support schedulerName? #13745

Closed
631068264 opened this issue Feb 27, 2023 · 1 comment
Closed

serving support schedulerName? #13745

631068264 opened this issue Feb 27, 2023 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@631068264
Copy link

What version of Knative?

I use kubeflow 1.6.1 . According to it use Knative 1.2.5

I want to use GPU share feature for predictor via kubeflow + volcano . But I get error

I apply this

apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "volcano"
spec:
  predictor:
    schedulerName: volcano
    containers:
      - name: kserve-container
        image: xxx:8080/library/model/firesmoke:v1
        env:
          - name: MODEL_NAME
            value: volcano
        command:
          - python
          - -m
          - fire_smoke
        resources:
          limits:
            volcano.sh/gpu-memory: 2048

error

Events:
  Type     Reason         Age                    From                Message
  ----     ------         ----                   ----                -------
  Warning  InternalError  3m4s (x17 over 8m32s)  v1beta1Controllers  fails to reconcile predictor: admission webhook "validation.webhook.serving.knative.dev" denied the request: validation failed: must not set the field(s): spec.template.spec.schedulerName

Expected Behavior

Actual Behavior

Steps to Reproduce the Problem

@631068264 631068264 added the kind/bug Categorizes issue or PR as related to a bug. label Feb 27, 2023
@maidol
Copy link

maidol commented Feb 28, 2023

source code

...
	if cfg.Features.PodSpecSchedulerName != config.Disabled {
		out.SchedulerName = in.SchedulerName
	}
	if cfg.Features.PodSpecInitContainers != config.Disabled {
		out.InitContainers = in.InitContainers
	}
...

to enabled special schedulername feature

kubectl edit cm config-features -n knative-serving
apiVersion: v1
kind: ConfigMap
metadata:
  name: config-features
  namespace: knative-serving
data:
  kubernetes.podspec-schedulername: enabled # enabled special schedulername feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants