Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to manually configure maxSurge for Knative Serving's Service corresponding Deployment #13800

Closed
wenzhaojie opened this issue Mar 20, 2023 · 2 comments
Labels
kind/question Further information is requested lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/needs-user-input Issues which are waiting on a response from the reporter

Comments

@wenzhaojie
Copy link

Ask your question here:

I found that I am unable to manually configure maxSurge for Knative Serving's Service. I used the kubectl edit deployment command to add {"spec":{"strategy":{"rollingUpdate":{"maxSurge":"100%","maxUnavailable":0}}}}, but the changes did not take effect.

What could be the reason for this? How can I resolve this?

Thank you!

@wenzhaojie wenzhaojie added the kind/question Further information is requested label Mar 20, 2023
@skonto
Copy link
Contributor

skonto commented Mar 20, 2023

Hi @wenzhaojie , Knative Serving defines an API to create enhanced services on K8s. This means that it has a controller logic that creates at the end of the day the deployment on behalf of the user (it creates a number of other resources too), with some specific defaults (there is an issue about that btw) and it will reconcile the deployment accordingly. The autoscaler mechanism manages deployment changes (eg. replicas during upgrades) on behalf of the user, based on statistics collected from the queue proxy side-car (injected along with user-containers), see more the discussion here, where maxSurge 25% (default) and why it is used.

@dprotaso dprotaso added the triage/needs-user-input Issues which are waiting on a response from the reporter label Mar 20, 2023
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/needs-user-input Issues which are waiting on a response from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants