Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-request: Simplify control plane with a consolidated deployment #13965

Open
skonto opened this issue May 9, 2023 · 3 comments
Open

Feature-request: Simplify control plane with a consolidated deployment #13965

skonto opened this issue May 9, 2023 · 3 comments
Assignees
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)

Comments

@skonto
Copy link
Contributor

skonto commented May 9, 2023

Describe the feature

Istio long ago evaluated their deployment strategy and they switched to a more consolidated model.

Right now we have a number of components that are installed by default and could be merged into one.

For example:

  • domain-mapping
  • domainmapping-webhook
  • net-*-controller
  • net-istio-webhook
  • webhook
  • controller
  • autoscaler

With a consolidated model we get some immediate benefits:

cc @ReToCode @dprotaso @rhuss @evankanderson @psschwei @nak3

@skonto skonto added the kind/feature Well-understood/specified features, ready for coding. label May 9, 2023
@dprotaso
Copy link
Member

dprotaso commented May 9, 2023

I know various controllers have filtered informers setup with labels/namespaces - does it work when collapsing everyting into a single process?

I'm wondering if we have some limits in how we do dependency injection

@skonto
Copy link
Contributor Author

skonto commented May 11, 2023

I know various controllers have filtered informers setup with labels/namespaces - does it work when collapsing everyting into a single process?

We will have to adjust the informers to filter a set of labels instead of one per controller. I have tried that before at the net-istio side so it should work.

Previous work in this area https://github.com/mattmoor/mink/blob/b9148a39b2d8bbc69ca9aaf5e89a7613c0b179d8/config/core/deployments/dataplane.yaml merged things in one pod as a first step. We have some options but I would like to explore the idea of having everything in a process at least for the control plane as some stuff seem too much to be on their own.
This does not need to happen at one step, could be done incrementally. Initially we could have controller, webhook, domain webhook merged and solve any issues one by one.

In general I see a good opportunity here for using Knative in other environments with small footprint requirements like edge.

@skonto
Copy link
Contributor Author

skonto commented May 11, 2023

/assign skonto

@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

3 participants