Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple wildcard certificate domains #14364

Closed
arsenetar opened this issue Sep 13, 2023 · 2 comments · Fixed by #14543
Closed

Support multiple wildcard certificate domains #14364

arsenetar opened this issue Sep 13, 2023 · 2 comments · Fixed by #14543
Assignees
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@arsenetar
Copy link
Contributor

Describe the feature

Add ability to have multiple wildcard certificate domains. Currently only the default domain creates per namespace wildcard certificates. Would like the ability to specify multiple wildcard domains. Proposed method would be to flag the domains in the domain config to mark them as wildcard:

    example.com: |
      wildcard: true
      selector:
        app: secret

This format should be reverse compatible with the existing configuration. The default domain still would use wildcard, but would allow potentially for disabling wildcard for the default domain if desired.

I have an initial version of code that provides this functionality from the configuration loading, and the actual wildcard certificate creation.

@arsenetar arsenetar added the kind/feature Well-understood/specified features, ready for coding. label Sep 13, 2023
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 13, 2023
@dprotaso
Copy link
Member

/assign @arsenetar
/triage accepted

@dprotaso dprotaso reopened this Jan 13, 2024
@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jan 13, 2024
@dprotaso dprotaso added this to the v1.14.0 milestone Jan 13, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Well-understood/specified features, ready for coding. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants