route status incorrect for two named traffic targets pointing to same revision

[dgerd]

/area api
/area networking
/kind bug

Expected Behavior

For every traffic target in spec there should be a traffic target in status with a resolved revisionName.

Spec:

  traffic:
  - configurationName: hello-world
    name: alsotwo
    percent: 1
  - name: one
    percent: 50
    revisionName: hello-world-00001
  - name: two
    percent: 49
    revisionName: hello-world-00002

Status:

  traffic:
  - name: alsotwo
    revisionName: hello-world-00002
    percent: 1
  - name: one
    percent: 50
    revisionName: hello-world-00001
  - name: two
    percent: 49
    revisionName: hello-world-00002

Actual Behavior

If you create a route with multiple named traffic targets pointing to a same revision (using either configurationName or revisionName) one of them gets lost in translation to the status output.

I believe the issue is here:

serving/pkg/reconciler/v1alpha1/route/traffic/traffic.go

Line 226 in c850771

func consolidateAll(targets map[string][]RevisionTarget) map[string][]RevisionTarget {

where routes are consolidated together. While the consolidation is useful for creating the virtualservice, we lose information for displaying status.

Spec:

  traffic:
  - configurationName: hello-world
    name: alsotwo
    percent: 1
  - name: one
    percent: 50
    revisionName: hello-world-00001
  - name: two
    percent: 49
    revisionName: hello-world-00002

Status:

  traffic:
  - name: alsotwo
    percent: 50
    revisionName: hello-world-00002
  - name: one
    percent: 50
    revisionName: hello-world-00001

Steps to Reproduce the Problem

1. Create a revision
2. Create a route with two named traffic targets pointing to the revision created in Step 1
   • The first traffic target in the list will be displayed in status while the second one will be missing. In the script below this will mean that "foo" will show up, but "bar" will be missing.

Additional Info

Script to reproduce (you will need to replace "REPLACEME" with the path to an image)

#!/bin/bash

CONFIGURATION_NAME='hello-world'
IMAGE_LOCATION='gcr.io/REPLACEME'

cat << EOF | kubectl apply -f -
apiVersion: serving.knative.dev/v1alpha1
kind: Configuration
metadata:
  name: ${CONFIGURATION_NAME}
  namespace: default
spec:
  revisionTemplate:
    spec:
      container:
        image: ${IMAGE_LOCATION}
        env:
          - name: TARGET
            value: "Go Sample v3"
EOF

cat << EOF | kubectl apply -f -
apiVersion: serving.knative.dev/v1alpha1
kind: Route
metadata:
  name: ${CONFIGURATION_NAME}
  namespace: default
spec:
  traffic:
  - configurationName: ${CONFIGURATION_NAME}
    percent: 50
    name: "foo"
  - configurationName: ${CONFIGURATION_NAME}
    percent: 50
    name: "bar"
EOF

[tcnghia]

/assign @tcnghia

[tcnghia]

/remove-area api