Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict in VirtualService host when we have routes with same name (of different namespace) #2359

Closed
lichuqiang opened this issue Oct 31, 2018 · 3 comments
Labels
area/networking kind/bug Categorizes issue or PR as related to a bug.
Projects
Milestone

Comments

@lichuqiang
Copy link
Contributor

lichuqiang commented Oct 31, 2018

Expected Behavior

Value of Host should be unique across VirtualServices

Actual Behavior

When we have two routes (kservice) of same name in two namespaces. we will end up see same host value (route name) in their VirtualServices.

Steps to Reproduce the Problem

  1. create kservice square in namespace foo
  2. create kservice square in namespace bar
  3. check the hosts value in their VirtualServices

Additional Info

We probably want to remove the base host name to avoid this issue
We might also need a way to distinguish altnames vs hosts

@knative-prow-robot knative-prow-robot added area/networking kind/bug Categorizes issue or PR as related to a bug. labels Oct 31, 2018
@mattmoor
Copy link
Member

/kind good-first-issue

@lichuqiang
Copy link
Contributor Author

lichuqiang commented Nov 5, 2018

As users can easily hit the issue (especially during debugging, say deploy helloworld demo in two namespaces), and currently the route name specified in hosts is not taking effect.
I'd like to remove it first, and leave the issue open, to see if we'll need other update later

@mattmoor
Copy link
Member

mattmoor commented Nov 6, 2018

@tcnghia why not close this?

@tcnghia tcnghia closed this as completed Nov 6, 2018
@mattmoor mattmoor added this to Done in Serving 0.3 Nov 7, 2018
@mattmoor mattmoor modified the milestone: Serving 0.3 Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Serving 0.3
  
Done
Development

No branches or pull requests

4 participants