Set KO_DATA_PATH when running tests

[mattmoor]

I see the following in our e2e test logs. I believe this is because our default logging package is used by our test code as well and the knative/pkg/changeset package is trying and failing to find $KO_DATA_PATH/HEAD:

I1110 06:24:54.159] 2018-11-10T06:20:18.474Z	warn	logging/config.go:41	Fetch GitHub commit ID from kodata failed: "KO_DATA_PATH" does not exist or is empty

I believe we could get commit information in our e2e log output if we set KO_DATA_PATH=$REPO_ROOT/.git before invoking the tests.

cc @adrcunha

[mattmoor]

cc @yanweiguo

[adrcunha]

Setting KO_DATA_PATH as you suggested and running the tests locally (in a branch called kodata) results in a similar error:

2018-11-13T21:51:32.502-0800    warn    logging/config.go:41    Fetch GitHub commit ID from kodata failed: "ref: refs/heads/kodata" is not a valid GitHub commit ID

[yanweiguo]

The test branch is a non-committed branch. The content of .git/HEAD is "ref: refs/heads/" instead of a commit ID. If the test is run in a committed branch, there should not be such warning.

[adrcunha]

Is this error expected even when the change is in a PR (i.e., not yet merged to the master branch)? Like https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2526/pull-knative-serving-integration-tests/1064981887061069826/

[yanweiguo]

Is this error expected even when the change is in a PR (i.e., not yet merged to the master branch)? Like https://gubernator.knative.dev/build/knative-prow/pr-logs/pull/knative_serving/2526/pull-knative-serving-integration-tests/1064981887061069826/

Yes

[rprakashg]

I'm seeing this in logs when my build fails too.

[yanweiguo]

I'm seeing this in logs when my build fails too.

This log is a warning and it won't break build.

[adrcunha]

Still doesn't work... Or maybe I'm doing something wrong.

#2526 is merged, it added KO_DATA_PATH for the E2E tests.

My test PR (#2672) shows the same error:

1207 22:56:20.122] 2018-12-07T22:45:11.163Z	warn	logging/config.go:41	Fetch GitHub commit ID from kodata failed: "ref: refs/heads/test" is not a valid GitHub commit ID

As you can see in https://prow.knative.dev/log?job=pull-knative-serving-integration-tests&id=1071170919482789888 (search for the message above)

[yanweiguo]

Still doesn't work... Or maybe I'm doing something wrong.

#2526 is merged, it added KO_DATA_PATH for the E2E tests.

My test PR (#2672) shows the same error:

1207 22:56:20.122] 2018-12-07T22:45:11.163Z	warn	logging/config.go:41	Fetch GitHub commit ID from kodata failed: "ref: refs/heads/test" is not a valid GitHub commit ID

As you can see in https://prow.knative.dev/log?job=pull-knative-serving-integration-tests&id=1071170919482789888 (search for the message above)

KO_DATA_PATH tells where to fetch the HEAD file. The context in the file can be "ref: refs/heads/<branch-name>" if the branch is not merged or a commit ID if the branch was merged. There will only be no warns if KO_DATA_PATH is set and the docker images are built from a merged branch.

[adrcunha]

Thanks for the clarification, Yanwei. This is WAI then and knative/test-infra#304 sets the generic approach.