Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClusterIngress controller needs better coverage #3089

Closed
mattmoor opened this issue Feb 4, 2019 · 2 comments
Closed

ClusterIngress controller needs better coverage #3089

mattmoor opened this issue Feb 4, 2019 · 2 comments
Assignees
@tcnghia
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
0.5.x

Comments

@mattmoor
Copy link
Member

mattmoor commented Feb 4, 2019

clusteringress.go is 78% < 80% so it fails PRs that touch it.

cc @tcnghia @lichuqiang
@knative-prow-robot knative-prow-robot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 4, 2019
@tcnghia
Copy link
Contributor

tcnghia commented Feb 5, 2019

/assign

@mattmoor
Copy link
Member Author

... over 80%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcnghia tcnghia

Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
0.5.x
Development

No branches or pull requests
3 participants
@tcnghia @mattmoor @knative-prow-robot