Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Enter Name' bug [React.js Beginners] #19

Closed
ashokdey opened this issue Oct 7, 2019 · 4 comments
Closed

Fix 'Enter Name' bug [React.js Beginners] #19

ashokdey opened this issue Oct 7, 2019 · 4 comments

Comments

@ashokdey
Copy link
Member

ashokdey commented Oct 7, 2019

On the main page, if you try to add a name that is less than 4 chars, the input field has a bug that carries the place holder text as the input text.

Notes:

  • Make sure other parts of the app is not breaking
  • Make sure ESLint rules are not breaking
  • Make sure to open your PR in Develop branch

⭐️ If you like the work, do star the repo ⭐️

All the best.

@PranjalAgni
Copy link

Can I work on this?

@ashokdey
Copy link
Member Author

ashokdey commented Oct 7, 2019

Sure @PranjalAgni, I am assigning you this issue, you got 10 hrs to submit this and also star the repo if you liked it.

@haichuan0424
Copy link

I'd like to work on this too if the other person does not submit PR within your requested time.

@ashokdey
Copy link
Member Author

ashokdey commented Oct 7, 2019

#21 by @PranjalAgni closes this. Good to see your interest @haichuan0424, you can look at #20

@ashokdey ashokdey closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants