Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save to JSON should use null, not encode <nil> as a string #17

Closed
artfulrobot opened this issue May 20, 2023 · 2 comments · Fixed by #28
Closed

Save to JSON should use null, not encode <nil> as a string #17

artfulrobot opened this issue May 20, 2023 · 2 comments · Fixed by #28
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@artfulrobot
Copy link

The JSON save method encodes NULL sql values as "\u003cnil\u003e". It should simply output null.

screenshot
@kndndrj
Copy link
Owner

kndndrj commented May 20, 2023

Agree!

It just isnt a prio atm.

If you wish, you can explore a bit around this in dbee/outputs/json.go

@kndndrj kndndrj added bug Something isn't working good first issue Good for newcomers labels May 20, 2023
@artfulrobot
Copy link
Author

Never written a line of Go before, so I'll leave that as someone else's good first issue! Thanks.

@kndndrj kndndrj mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/storing results kndndrj/nvim-dbee
2 participants
@artfulrobot @kndndrj