Prevent multiple connections from running migrations at the same time #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elhigu
commented
Dec 13, 2015
elhigu
commented
- Adds locking when migrations are started
- forceFreeMigrationsLock function to allow removing the lock manually
Closed
elhigu
force-pushed
the
migration-lock
branch
from
51b10f2
to
184e8ca
Compare
|
@rhys-vdw could you give this the final review. @dustinmartin made this almost ready, but didn't have time to give it a last touch in #1067. |
elhigu
force-pushed
the
migration-lock
branch
from
184e8ca
to
7e274f5
Compare
|
@elhigu Yep, will review this evening. |
| return this._isLocked(trx) | ||
| .then(isLocked => { | ||
| if (isLocked) { | ||
| throw new Error("Migration table is are already locked"); |
|
@elhigu Looking good. |
elhigu
force-pushed
the
migration-lock
branch
from
7e274f5
to
3dd5ac8
Compare
elhigu
added a commit
that referenced
this pull request
Dec 15, 2015
Prevent multiple connections from running migrations at the same time
|
@elhigu Thanks or finishing this up. Very much appreciated. When do you think the next release of knex will be that will include these changes? |
|
@dustinmartin Should do one soon. @elhigu is there anything else you'd like to see in the next release? |
|
@rhys-vdw there is still that one pull request about sqlite3 dialect escaping which I would like to get in. It fixes also some regressions from postgres string literal escaping from getting to release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.