Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seed file stub is buggy #1470

Closed
elhigu opened this issue Jun 5, 2016 · 1 comment
Closed

Seed file stub is buggy #1470

elhigu opened this issue Jun 5, 2016 · 1 comment
Labels
bug

Comments

@elhigu
Copy link
Member

elhigu commented Jun 5, 2016

Seed file stub is using Promise.join in a wrong way which causes undefined behavior due to race conditions when sending queries... could be that it works when all queries is sent to same connection but actually nothing in Promise.join guarantees order in which promises are resolved...
#1243 Has some more discussion about it.
@elhigu elhigu added the bug label Jun 5, 2016
@dannyfritz
Copy link
Contributor

Been having some problems using Promise.join today. Intermittent fails when running knex seed:run and it is supposed to drop the table before inserting rows.

@dannyfritz dannyfritz mentioned this issue Jun 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dannyfritz @elhigu @rhys-vdw