Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: async, promise returning nature of migration and seed APIs #1656

Open
jmm opened this issue Sep 9, 2016 · 1 comment
Open

Documentation: async, promise returning nature of migration and seed APIs #1656

jmm opened this issue Sep 9, 2016 · 1 comment
Labels
docs

Comments

@jmm
Copy link

jmm commented Sep 9, 2016

The async, promise returning nature of the migration and seed methods (e.g. knex.migrate.rollback(), knex.seed.run()) should be clearly documented. It seems to only be hinted at by a code example.
@elhigu
Copy link
Member

elhigu commented Sep 9, 2016

Looks like you are right. Pull requests, improving documentation are always welcome 👍

@elhigu elhigu added the docs label Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmm @elhigu