ONLY keyword support for PostgreSQL #1874
Conversation
… from() and into() through table(tableName, only)
|
Sounds like ONLY is actually not postgresql specific functionality, but comes from standard... any ideas if mysql or others support it? Generally pull request looks good, change is so simple that I'm fine that there is no integration tests for this since the change is so simple. One thing there is that I would like to change. Instead of true/false parameter would be more future proof to pass Could you make also pull request to documentation repository and add link to it here, so I can check that documentation will be |
|
and thanks for contribution 👍 ! |
|
Hey @elhigu! Thanks so much for the feedback. From Google searches, I would say Postgres is the only one supporting it, as other engines don't seem to support table inheritance in the same way (but I may be wrong, not a DBA). I'll see if I can take a look at your request this coming week and update this PR accordingly. |
|
Hey @elhigu, You may find the new docs here: knex/documentation#16 |
| this._single.table = tableName; | ||
| this._single.only = options.only !== undefined ? options.only : false; |
There was a problem hiding this comment.
Try to prevent negated conditions where possible. Here it would make more sense with explicit checks this._single.only = options.only === true as it would also ensure the property only is always a boolean. :)
There was a problem hiding this comment.
taken care of ;) thanks!
|
Thanks @tomaspinho |
|
Thank you, @elhigu 😄 |
* adding support for ONLY keyword for PostgreSQL as an optional flag of from() and into() through table(tableName, only) * passing only parameter from default function was missing * changing only option to options object with only key * better style per @wubzz suggestion
Hello, we're requiring the ability to use the
ONLYkeyword in PostgreSQL and I have done a crude implementation of it in this PR.Please discuss and provide any comments that would enable this or other PR to be merged that implements the same functionality.
Thank you!