Support passing connection override to a query #2817
Conversation
|
@elhigu If this looks OK, I'll also prepare a documentation PR. |
|
@elhigu Any chance reviewing this could be prioritized? We were suddenly hit with a weird behavior of Google Cloud SQL and this is the only way to work around it, and using private forks in production is typically a terrible idea. |
…re/2804-passing-connection # Conflicts: # test/unit/knex.js
… into feature/2804-passing-connection
|
I would love to get this in. This will add support to lots of stuff that can be done with knex when one can choose to use the same connection for multiple queries without using transactions. |
…re/2804-passing-connection
|
Documentation added, tests pass after latest fix to the master. Are there any gotchas to handling connections inside Knex that I am not aware of and that are relevant to this change? |
|
I forgot to merge this for next release... I'll do another one 😅 |
|
woohoo! thanks a lot! |
|
done! |
|
Great news, thank you so much! |
|
Maybe after oracledb is fixed again we could think about real release... gotta go through which pull requests are still in progress. |
|
Sounds good! I guess #2608 is probably one of the most important not-yet-merged PRs, but looks like it was abandoned and no tests are coming :(. Fixing the regression for PostgreSQL streaming error handling (#2638) would also be nice, I guess. @fcmatteo any chance you could have some time to take a look at it? |
implements #2804