Make TS stubs modern #3080
Make TS stubs modern #3080
Conversation
| t.increments(); | ||
| t.timestamps(); | ||
| }); | ||
| }; | ||
| } |
There was a problem hiding this comment.
Why remove semicolons, though?
There was a problem hiding this comment.
Normal function declaration shouldn't have semicolon there. With arrow function, it would be obligatory though.
There was a problem hiding this comment.
@felixmosh So if I understand correctly, semicolons should be restored, since it's an arrow function?..
There was a problem hiding this comment.
@kibertoad , no, up is not an arrow function :]
The function that we pass to createTable is an arrow func, and there are semi-colons there.
| @@ -1,9 +1,9 @@ | |||
| import * as Knex from "knex"; | |||
|
|
|||
| exports.seed = function (knex: Knex): Promise<any> { | |||
| export async function seed(knex: Knex): Promise<any> { | |||
There was a problem hiding this comment.
if it returns promise anyway, why make it async?
There was a problem hiding this comment.
To allow using await inside the function.
There was a problem hiding this comment.
Await inside the function is kinda broken, though, not sure we want to encourage it: #2581
There was a problem hiding this comment.
Yes we do :) That is really strange though. It doesn't make sense at all that it works when calling then(), but not with await... Maybe we have missed returning a promise from .then somewhere 🤔
There was a problem hiding this comment.
I'll try writing a failing test for that case.
Small refactor to the TS stubs, so they will use arrow functions and es6 import / export.