Add boolean as a column value type in join

[felixmosh]

Added missing type

[kibertoad]

When would it be a boolean?

[felixmosh]

What do you mean?
The value of join can be boolean :)

[kibertoad]

Could you please provide example code that was invalid before this change?
The way I'm reading this binding is this:

knex('users')
  .join('contacts', 'users.id', '=', 'contacts.user_id')
  .select('users.id', 'contacts.phone')

columns are these: 'users.id', '=', 'contacts.user_id'
Why would they ever be boolean?

[felixmosh]

Pay attention to the interface that I've fixed, it is the one that accepts an object.

db('tableName')
    .leftJoin('otherTable', {
      'tableName.isDefault': true
    })

It tries to resolve it using the Raw interface because there is no boolean.

[kibertoad]

Fair enough. And if typing is fixed, DB understands boolean value correctly?

[felixmosh]

Yeah, it works, it converts it into tinyInt automatically

[elhigu]

Actually that depends highly on db that is used, but something like that :) I had big problems trying to write cross db compatible code that had used boolean column type.