Type Definitions: Awaiting on knex queries violates no-invalid-await rule from SonarTS

[KristjanTammekivi]

Environment

Knex version: 0.20.1
Database + version: Postgres 11.4
OS: Ubuntu 18.04

If issue is about TypeScript definitions, tag @lorefnon

This might be considered a duplicate of #3515, two sides of the same coin sort of deal

Bug

1. Awaiting on querybuilders/raw queries violates no-invalid-await rule in tslint-sonarts. This worked on 0.19.2 but not on 0.20.1

2. Refactor this redundant 'await' on a non-promise. (no-invalid-await)

3. await knex('users').select('*').limit(1);

[lorefnon]

I think this happens because their hasThenMethod checks if .then property has ts.SymbolFlags.Method flag set which won't be in our case because we use a callable interface for the then property of QueryBuilder so then technically doesn't qualify as a method.

Maybe report this in the SonarTS repo with a minimal reproducer like:

interface SomeCallable {
    (cb: Function): Promise; 
} 

interface Builder {
    then: SomeCallable;
}

This would have worked before because QueryBuilder extended Promise interface which had a then method.

[KristjanTammekivi]

Reported it in sonarts now, closing this one