Fix debug logger messing up queries with % #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Dec 7, 2019
lib/client.js
Outdated
| const debugBindings = require('debug')('knex:bindings'); | ||
|
|
||
| const debugQuery = (sql, txId) => _debugQuery(sql.replace(/%/, '%%'), txId) |
There was a problem hiding this comment.
wouldn't that mess up queries that had %% in them already? or that is not a realistic case? maybe we can limit regexp to just single instances of %?
There was a problem hiding this comment.
I intended this to be /%/g.
Although I cant imagine a situation where we would have multiple consecutive % in an sql query, if we do, I think we would always want them to be reported as many as there are.
> debug('x')('%foo%')
x NaNoo%
> debug('x')('%%foo%%')
x %foo% +0ms
> debug('x')('%foo%'.replace(/%/g, '%%'))
x %foo% +0ms
> debug('x')('%%foo%%'.replace(/%/g, '%%'))
x %%foo%% +0ms
kibertoad
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3564