You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The batchInsert functionality is incredibly inefficient. Shouldn't it utilize the underlying driver's utilities for batch processing? I.e., for mssql it should use
IMO batch insert should not even exist in knex level, since it iis more of a helper than a single query that is built.
Anyways if this kind of optimization is implemented to mssql dialect with good integration tests that it works the same way with other drivers I don't have any reason why not to accept PR for this (if it doesn't complicate any other parts in knex).
The batchInsert functionality is incredibly inefficient. Shouldn't it utilize the underlying driver's utilities for batch processing? I.e., for mssql it should use
https://github.com/tediousjs/node-mssql#bulk-table-options-callback
The text was updated successfully, but these errors were encountered: