Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__knexQueryUid not generated for ROLLBACKs #3624

Open
pdemarino opened this issue Jan 14, 2020 · 2 comments
Open

__knexQueryUid not generated for ROLLBACKs #3624

pdemarino opened this issue Jan 14, 2020 · 2 comments

Comments

@pdemarino
Copy link

Environment

Knex version: 0.20.7
Database + version: MySQL 5.6 (RDS)
OS: Lambda

Bug / Missing documentation?

Issue

Rollbacks generated by Knex should lead to a unique query ID being generated and reported through the event mechanism (Knex.on("query-response", (resp,obj)=> { ... }).

Instead, I am seeing events like these:

"obj": {
        "__knexUid": "__knexUid1",
        "__knexTxId": "trx2",
        "sql": "ROLLBACK"
    },
@pdemarino
Copy link
Author

I also noticed this missing from a number of table definition calls.

"obj": {
        "__knexUid": "__knexUid1",
        "__knexTxId": "trx2",
        "sql": "alter table `wss_tokens` add index `wss_tokens_user_sub_index`(`user_sub`)",
        "bindings": []
    },

@EliteMasterEric
Copy link

I have noticed this bug also occurs for "CREATE TABLE" queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants