Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new config parameter / CLI flag to prefixing seed filename with a timestamp #3873

Merged
merged 6 commits into from Sep 19, 2020

Conversation

christianodejesus
Copy link
Contributor

@christianodejesus christianodejesus commented Jun 6, 2020

I've created the new timestampFilenamePrefix seeder config parameter and --timestamp-filename-prefix CLI flag to prefixing seed filenames with a timestamp, like migration files.

Documentation PR: knex/documentation#271

Close #3623.

bin/cli.js Show resolved Hide resolved
bin/cli.js Show resolved Hide resolved
lib/seed/Seeder.js Outdated Show resolved Hide resolved
lib/util/timestamp.js Outdated Show resolved Hide resolved
Copy link
Contributor Author

@christianodejesus christianodejesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit added to PR.

lib/seed/Seeder.js Outdated Show resolved Hide resolved
lib/util/timestamp.js Outdated Show resolved Hide resolved
@kibertoad
Copy link
Collaborator

@christianodejesus Sorry for the delay in merging this. If you could resolve conflicts, I'll merge.

@christianodejesus
Copy link
Contributor Author

christianodejesus commented Sep 19, 2020

@kibertoad I did a merge from knex/master and conflicts are resolved. Ok!?

@kibertoad kibertoad merged commit a481dde into knex:master Sep 19, 2020
@kibertoad
Copy link
Collaborator

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix seeds with timestamp like migrations
2 participants