Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batchInsert fix return type in typings #4068

Closed
maximelkin opened this issue Oct 19, 2020 · 1 comment · Fixed by #4131
Closed

batchInsert fix return type in typings #4068

maximelkin opened this issue Oct 19, 2020 · 1 comment · Fixed by #4131

Comments

@maximelkin
Copy link
Collaborator

maximelkin commented Oct 19, 2020

Environment

Knex version: latest
Database + version: any
OS: any

Select applicable template from below.
If issue is about oracledb support, tag @ atiertant. For MSSql tag @ smorey2.
Rest of dialects don't need tags.
If issue is about TypeScript definitions, tag @lorefnon.

Bug

  1. Explain what kind of behaviour you are getting and how you think it should do
    knex.batchInsert as for documentation returns knex.QueryBuilder
    actually it is Promise & {returning, transacting}
@kibertoad
Copy link
Collaborator

Released in 0.21.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants