knex('table').having({ field: 'value' }).del() silently deletes ALL rows!

[reza-akbari]

Environment

Knex version: 0.21.5
Database + version: postgres 13.0
OS: alpine

Bug

Explain what kind of behaviour you are getting and how you think it should do:

running

knex('table').having('some_relation_count', '>', 0).del()

silently removes "having" and results in

delete from "table"

I executed a similar select query to check the effected rows and then executed the delete query.
fortunately I had backups!

I think knex could throw an error or let the database throw a syntax error by not removing the "having" part
Thank you for this great project

[elhigu]

This actually might be a bug... I suppose knex should compile something like:

delete from "table" having "some_relation_count" > 0;

even if query would be invalid. At least with select when one uses having it is included to the query https://runkit.com/embed/bsltlf434drq

That error throwing might be potential feature request. Knex maybe could throw an error if query contains parts that were ignored in compilation... though I'm not sure if that is viable to implement, since compilers should then keep track which parts were actually used.