Fix issue with schema usage with FROM clause #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saka7
changed the title
|
IMHO, In case this PR is merged we should implement #3654 as well for consistency |
kibertoad
reviewed
Feb 2, 2021
lib/query/querycompiler.js
Outdated
| const isRawQuery = tableName instanceof Raw; | ||
| const isFunction = typeof tableName === 'function'; | ||
|
|
||
| if (tableName && schemaName && !isQueryBuilder && !isRawQuery && !isFunction) { |
There was a problem hiding this comment.
Since last three checks are only relevant if first three pass, I would split checks in two blocks and only resolve these conditions if first two pass.
|
@Saka7 I agree. Can you either add the change to this PR or open a separate one? |
|
Also there are conflicts now. |
kibertoad
approved these changes
Feb 3, 2021
|
Thank you! |
mike183
added a commit
to status200/knex
that referenced
this pull request
Dec 9, 2021
Fix taken from knex#4268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #1368
Related issues: #2054, #3654
Description
Prevent adding a
schema(specified by.withSchema) to a.fromcaluse containing aQueryBuilder,Raworfunction.