Recreate indices when altering a table in SQLite #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Feb 5, 2021
|
Great job! Other than minor naming nitpick, looks amazing. |
nickrum
force-pushed
the
sqlite-recreate-index-feature
branch
from
41df15e
to
5529c48
Compare
|
Thanks! The naming should be fixed. |
kibertoad
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to separate the parsing and the altering logic as much as possible.
When querying
sqlite_masterfor create index statements, it seems like only the first part of those statements is in uppercase. It would be nice if the casing was consistent but when I tried to uppercase the index creation statements in the SQLite TableCompiler, nearly all tests failed with cryptic errors.