Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missleading Typescript Type For onDelete on onUpdate Function #4620

Closed
zeotuan opened this issue Aug 14, 2021 · 0 comments · Fixed by #4656
Closed

Missleading Typescript Type For onDelete on onUpdate Function #4620

zeotuan opened this issue Aug 14, 2021 · 0 comments · Fixed by #4656

Comments

@zeotuan
Copy link
Contributor

zeotuan commented Aug 14, 2021 •
edited

Environment

Knex version:
Latest release knex 95.8

@lorefnon.

Bug

  1. At the Moment, Knex only support onDelete and onUpdate with foreignKey constraint but typescript suggest that onDelete and onUpdate can be chained off Column. The documentation also suggest that onUpdate and onDelete can be chained of Column but it actually does nothing

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix onDelete/onUpdate for ColumnBuilder maximelkin/knex
1 participant
@zeotuan