You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying out the new better-sqlite3 driver in Knex 1.x (due to the maintenance questions I saw with sqlite3 and @vscode/sqlite3). I ran into a problem within my application's code: Knex's better-sqlite3 driver encodes booleans as string literals ('true' and 'false'), instead of as 0 and 1. This seems like a bug:
It's incompatible with Knex's sqlite3 driver, so the better-sqlite3 driver can't be used as a drop-in replacement.
(For future reference, this issue is fixed in PR #4982, it can now be closed at the maintainers' convenience I believe, thanks @joshkel for finding and linking to the exact line of code that had to be changed)
Environment
Knex version: 1.0.1
Database + version: better-sqlite3 7.4.6
OS: macOS 12.1
Bug
I'm trying out the new better-sqlite3 driver in Knex 1.x (due to the maintenance questions I saw with sqlite3 and @vscode/sqlite3). I ran into a problem within my application's code: Knex's better-sqlite3 driver encodes booleans as string literals (
'true
' and'false'
), instead of as 0 and 1. This seems like a bug:'true'
and'false'
are truthy.The text was updated successfully, but these errors were encountered: