Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unexpected max acquire-timeout #5377

Merged
merged 1 commit into from Nov 17, 2022
Merged

Fixes unexpected max acquire-timeout #5377

merged 1 commit into from Nov 17, 2022

Conversation

MattGson
Copy link
Contributor

Important for applications where high pool contention is expected, and completion is favored over latency.

@coveralls
Copy link

coveralls commented Nov 11, 2022 •
edited

Coverage Status

Coverage increased (+0.0009%) to 92.335% when pulling bfdea34 on MattGson:fix/acquireConnectionTimeout into 5c4837c on knex:master.

@MattGson MattGson force-pushed the fix/acquireConnectionTimeout branch 3 times, most recently from 4913b7f to f28cebb Compare November 11, 2022 03:18
@MattGson
Copy link
Contributor Author

Failing for a js-doc linter but I have not touched any js-doc...

The 'no-redundant-jsdoc' rule threw an error in '/home/runner/work/knex/knex/types/index.d.ts':
Error: Unexpected tag kind: JSDocDeprecatedTag
    at checkTag (/home/runner/work/knex/knex/node_modules/tslint/lib/rules/noRedundantJsdocRule.js:105:23)
    at cb (/home/runner/work/knex/knex/node_modules/tslint/lib/rules/noRedundantJsdocRule.js:[62](https://github.com/knex/knex/actions/runs/3442216445/jobs/5742565292#step:5:63):25)
    at visitNodes (/home/runner/work/knex/knex/node_modules/typescript/lib/typescript.js:31095:30)
    at Object.forEachChild (/home/runner/work/knex/knex/node_modules/typescript/lib/typescript.js:31502:21)
    at cb (/home/runner/work/knex/knex/node_modules/tslint/lib/rules/noRedundantJsdocRule.js:67:19)
    at visitNodes (/home/runner/work/knex/knex/node_modules/typescript/lib/typescript.js:31095:30)
    at Object.forEachChild (/home/runner/work/knex/knex/node_modules/typescript/lib/typescript.js:31421:24)
    at cb (/home/runner/work/knex/knex/node_modules/tslint/lib/rules/noRedundantJsdocRule.js:[67](https://github.com/knex/knex/actions/runs/3442216445/jobs/5742565292#step:5:68):19)
    at visitNode (/home/runner/work/knex/knex/node_modules/typescript/lib/typescript.js:31086:24)
    at Object.forEachChild (/home/runner/work/knex/knex/node_modules/typescript/lib/typescript.js:31521:21)

@MattGson MattGson mentioned this pull request Nov 13, 2022
Closed
OlivierCavadenti
OlivierCavadenti requested changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error is here :

/home/runner/work/knex/knex/lib/client.js
216:39 error Parsing error: Identifier directly after number

@kiiwiz
Fixes unexpected max acquire-timeout
bfdea34 
Important for applications where high pool contention is expected, and completion is favored over latency.
@MattGson
Copy link
Contributor Author

The error is here :

/home/runner/work/knex/knex/lib/client.js 216:39 error Parsing error: Identifier directly after number

Ah, looks like the linter doesn't like numeric-separators

@OlivierCavadenti OlivierCavadenti merged commit 4fc939a into knex:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCavadenti OlivierCavadenti OlivierCavadenti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MattGson @coveralls @OlivierCavadenti @kiiwiz