New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readonly option to Better-SQLite3 #5530
Add readonly option to Better-SQLite3 #5530
Conversation
9a01254
to
68578c8
Compare
Co-authored-by: Adam Haglund <ahaglund@paypal.com>
68578c8
to
40764a2
Compare
Actions seems broken and we have no checks, I will try to fix that before merging. |
Hi, I have this error in tests, it's seems I can create a database with readonly: false (like before) but with readonly : true;
|
Hi, @OlivierCavadenti. Sorry about this! Looks like the tests were only passing intermittently, depending on whether a previous test case created |
Better-SQLite3 supports a
readonly
option on initialization. This PR lets Knex users set that option.(The automatic code formatter wanted to reflow some lines unrelated to the new code. I've split those automated changes out into a separate commit for clarity and to preserve author attribution on the changed lines.)
Docs PR is in knex/documentation#505.