Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

lr_cooler and clip_cooler doesn't work correctly #13

Closed
kngwyu opened this issue Apr 9, 2019 · 0 comments
Closed

lr_cooler and clip_cooler doesn't work correctly #13

kngwyu opened this issue Apr 9, 2019 · 0 comments

Comments

@kngwyu
Copy link
Owner

kngwyu commented Apr 9, 2019

def lr_cooler(self, initial: float) -> Cooler:

They subtracts (initial - minimum) / max_steps from the value every time they're called, but they are called only max_steps / (nstpes * nworkers) times in A2C, PPO and ACKTR.

This should be fixed and the benchmark in #8 should be done again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant