Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable/Redundant class variables #6

Open
kngwyu opened this issue Sep 30, 2019 · 0 comments
Open

Mutable/Redundant class variables #6

kngwyu opened this issue Sep 30, 2019 · 0 comments

Comments

@kngwyu
Copy link
Owner

kngwyu commented Sep 30, 2019

Currently, many classes of rlpy3 have many mutable class variables like Domain.
Apparently, this is a bad manner because it means we cannot create multiple instances of the class.
Or, we have also many cases where we override the class variable in __init__. In these cases, class variables are redundant.
So we should fix it so that

  • All class variables are immutable
  • No override for class variables
  • Immutable class variables should be UPPER_SNAKE_CASE for noticeability
@kngwyu kngwyu changed the title Mutable class variables Mutable/Redundant class variables Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant