Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better samples generation #21

Closed
oktomus opened this issue Jul 30, 2020 · 3 comments
Closed

Better samples generation #21

oktomus opened this issue Jul 30, 2020 · 3 comments

Comments

@oktomus
Copy link

oktomus commented Jul 30, 2020

We can see weird patterns in the samples.

image

Maybe it is related to the RNG ?

I had a similar issue that I fixed on my toy renderer using another RNG.

For reference:
@knightcrawler25
Copy link
Owner

Could be, but I'm unable to see those repetitive patterns on my PC. What GPU are you on?

@oktomus
Copy link
Author

oktomus commented Jul 30, 2020

RTX 2080.

Can you point me to the place where the samples are generated?

@knightcrawler25
Copy link
Owner

knightcrawler25 commented Jul 30, 2020 •
edited
Loading

The rand() function is in src/shaders/common/globals.glsl
and the seed is set in src/shaders/tiled.glsl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oktomus @knightcrawler25