Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with empty data frame #40

Closed
OCrylic opened this issue Jan 12, 2023 · 5 comments
Closed

Problem with empty data frame #40

OCrylic opened this issue Jan 12, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@OCrylic
Copy link

OCrylic commented Jan 12, 2023

Describe the problem
Hi @knightss27,

I use the Zabbix datasource and I have a problem when the query send an empty data frame.
I have a map with 50 queries and if only one of them is sending an empty data frame, it breaks the entire map and I have the error "a is undefined":
image
Having a query sending null values is normal and could happen as sometimes I have no value or my host or my interface does not exist in Zabbix yet. But it should not break the entire map.

Usually, when I have no value, the query send nothing (null or empty?). But I am using a specific function (to sum my series) that transform it into a data frame with no result and I think this is what is causing the problem.
Here is the example displaying the data in a table without and with the function I use. The second one fails in a network weathermap panel
OK in network weathermap panel (display 0 on link):
image

NOK in network weathermap panel (I have the error and cannot see the map in the panel)
image

To Reproduce
You can reproduce it with the Zabbix datasource as I showed in the screenshot, by putting a host or an interface that does not exists and using the sumseries function

Expected behavior
I expect the Network Weathermap panel not failing and display 0 or n/a if it is an empty data frame

Versions

  • Grafana version 9.3.1
  • Network Weathermap Plugin version 3.3
  • Zabbix plugin version 4.2.10
@OCrylic OCrylic added the bug Something isn't working label Jan 12, 2023
@knightss27
Copy link
Owner

Can you confirm whether this breaks using this query for both the "bandwidth" and normal throughput "query" fields? Or does it just break if you're using that query for bandwidth or only for the throughput? Or does the panel break even if you haven't added the query to a specific link?

@knightss27 knightss27 self-assigned this Jan 13, 2023
@OCrylic
Copy link
Author

OCrylic commented Jan 16, 2023

I confirm it breaks by using this kind of query in Side Query fields (A and Z) and Bandwidth Query fields (A and Z).
However, as long as I do not associate the query to one of those field, I have no issue.

@knightss27
Copy link
Owner

I pushed a possible fix for this with the new update that has just been released on Grafana. Please let me know if this still happens, and I'll try and debug it further.

@OCrylic
Copy link
Author

OCrylic commented Feb 1, 2023

Hi @knightss27

It did the trick, thank you

@ladvocat
Copy link

ladvocat commented Feb 1, 2023

I am having the same problem described in this case.
But instead of Zabbix, I use Influxdb v2.
When a router is down and the query fails to retrieve data, the map crashes.
I have tried to update to version 0.3.5 but it did not resolve the problem.
To replicate this behavior is as easy as to add a link connected to a "broken" query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants