-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time for a 1.30 release #32
Comments
A small remark. I did not have time to verify the mp4 container after corrections. Good correctness detectors are the MPD and Sony Walkman player. In previous versions, I had to use FFMPEG to fix the container. Or used MP4Box for containerization (aac -> m4a). |
There is a compiler error when compiling with VS 2019. In input.c the |
with the latest commit faac compiles now without errors. |
@zvezdochiot Any clue what was wrong with the mp4 containers created by faac? |
@fabiangreffrath say:
MPD just does not see them. |
@fabiangreffrath see:
Tested the git version on MPD. Sees. |
I assume that's a good sign. |
@fabiangreffrath say:
To understand what's under the hood, you need to take faac 1.28 and use https://github.com/madsen/vbindiff to look at the differences. But it takes time, I do not have it. (At 1.28 there was definitely a “bad” m4a container.) |
I am not going to do this, either. If you say the mp4 files produced by current git are properly recognized then I am fine with that. |
"Comment and close": |
I'd like to tag the current state of the code as a formal release.
@zvezdochiot @vividos @FoxesChen
You have contributed to the code lately. Is there anything missing in your opinion?
The text was updated successfully, but these errors were encountered: