Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping allowMidside breaks nearly all library consumers #8

Closed
ephemeralriggs opened this issue Nov 4, 2017 · 3 comments
Closed

Comments

@ephemeralriggs
Copy link

In commit 12d7414 the struct member allowMidside is dropped from faacEncConfiguration.

This breaks the build on virtually every consumer of libfaac. Due to the history of AAC in open source projects, many of those consumers are not frequently updated anymore.
For example, in FreeBSD we keep a (no longer maintained) package of ffmpeg before 1.0 around in order to support other infrequently maintained packages. This old ffmpeg package (and quite a few more, obviously) expect allowMidside.

Would it be possible to stay backward compatible for a certain grace period and keep the struct member allowMidside for now? This would allow the community to come up with the necessary workarounds in a release-friendly manner.

@knik0
Copy link
Owner

knik0 commented Nov 4, 2017

A trivial patch to all those packages: just don't set allowMidside and you're OK.

@ephemeralriggs
Copy link
Author

Thanks! Easy enough :-)

@ilovezfs
Copy link

@riggs- good news: backwards compatibility was restored as of 1.29.9.2 thanks to @enzo1982 and @knik0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants