Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--without-drm stopped working with 2.8 #15

Closed
dgilman opened this issue Oct 9, 2018 · 3 comments
Closed

--without-drm stopped working with 2.8 #15

dgilman opened this issue Oct 9, 2018 · 3 comments

Comments

@dgilman
Copy link

dgilman commented Oct 9, 2018

If you ./configure --without-drm in 2.8.x you will still get a libfaad_drm.2 shared object. The config.h is properly created with DRM undefied, there is something that is putting -DDRM into the CFLAGS in the makefile and that is forcing DRM to be defined at compile time.

@fabiangreffrath
Copy link
Collaborator

It doesn't build either one variant or the other anymore, but always builds both at once. I cannot see what's wrong with this.

@neheb
Copy link
Contributor

neheb commented Mar 11, 2020

This is the problem: 881b5e2

I will submit a patch partially fixing this.

@fabiangreffrath
Copy link
Collaborator

74e949f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants