Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loading nodes from jar files #57

Open
dietzc opened this issue Sep 22, 2016 · 0 comments
Open

Allow loading nodes from jar files #57

dietzc opened this issue Sep 22, 2016 · 0 comments

Comments

@dietzc
Copy link
Member

dietzc commented Sep 22, 2016

We want to be able to specify folders in the KNIME settings which can be used to discover Commands on KNIME startup (or just a single, pre-defined folder in the plugins folder of KNIME, e.g. commands-dropin).

We could simply add these folders to the KNIME URLClassLoader in a special implementation of the ResourceAwareClassLoader. However, we have to make sure that all dependencies are resolved gracefully. Therefore, I suggest the following:

  • Check the pom.xml in the .jar (if any, if not just load Command and hope that all dependencies are available).
  • Check all dependencies and find out if we have OSGi bundles for them available.
  • Create OSGi Fragment from pom.xml but replace all .jars which are available as OSGi bundles with Eclipse-Dependencies on these Bundles.
  • The resulting Fragment should only contain project specific .jars.

The very same mechanism can then later be used to create KNIME update-sites from ImageJ2 update-sites. Parts of the code is available in the current ImageJ2 integration (see https://github.com/knime-ip/knip-imagej2/blob/master/org.knime.knip.imagej2.core/src/org/knime/knip/imagej2/core/FragmentWrapperUtil.java).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant