Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subprocess.Popen() instead of subprocess.run() #25

Open
nithinth7 opened this issue Oct 12, 2020 · 2 comments
Open

Use subprocess.Popen() instead of subprocess.run() #25

nithinth7 opened this issue Oct 12, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@nithinth7
Copy link

It would be great if there is an enhancement to knimepy by using subprocess.Popen() instead of subprocess.run() with the option to use subprocess.SW_HIDE on Windows platforms. The main advantage of this in my point of view, there won't be any additional window opening up everytime I execute KNIME from python.

Based on: https://forum.knime.com/t/execute-knime-from-python/27903/2

@applio applio added the enhancement New feature or request label Oct 12, 2020
@applio applio self-assigned this Oct 12, 2020
@applio
Copy link
Collaborator

applio commented Oct 12, 2020

It probably makes sense to make subprocess.SW_HIDE the default on Windows, with an option to "unhide" it. It may make more sense to expose this as an attribute on the knime.Workflow class rather than as yet another option on execute().

@ryanwng12
Copy link

Hi, is there any status update regarding this enhancement? Would be looking forward for this to be included! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants