Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Feature request: Support additional prompts defined by commitizen adapters #5

Closed
chrisdevereux opened this issue Dec 20, 2016 · 6 comments

Comments

@chrisdevereux
Copy link

chrisdevereux commented Dec 20, 2016

Some custom commitizen configs define additional prompts (eg. https://github.com/atlassian/cz-lerna-changelog needs to know which packages in a monorepo to count a change as affecting).

Would be nice if vscode-commitizen could support these too. Maybe instead of hardcoding the series prompts, it could defer to the installed commitizen adaptor (perhaps by passing in a custom io interface in place of commitizen's inquirer.js instance?).

@KnisterPeter KnisterPeter changed the title Support additional prompts defined by commitizen adapters Feature request: Support additional prompts defined by commitizen adapters Dec 20, 2016
@KnisterPeter
Copy link
Owner

Nice idea

@chrisdevereux
Copy link
Author

Downside would be that a commitizen adaptor might try to read from stdin directly, which we couldn't intercept.

@KnisterPeter
Copy link
Owner

KnisterPeter commented Dec 20, 2016

Overwriting process.stdin isn't a nice idea 😱
It might not work with all adaptors, but I guess that would be okay.

@yetithefoot
Copy link

yetithefoot commented Mar 21, 2018

I'm using cz-customizable adapter that describes less strict rules (Skips some steps).
cz-customizable prompt relies on questions.js file that specifies inquirer questions pipeline. Is it poissible that extension also relies on that spec?

@KnisterPeter
Copy link
Owner

@yetithefoot I don't think that its a good idea to rely on a format which is inquirer dependent. That ties this format into this dependency. But you are right with the idea that the workflow in this extension should be configurable or extensible.

@stale
Copy link

stale bot commented Jul 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 21, 2020
@stale stale bot closed this as completed Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants