In value binding, simplify model "rejection" handling (don't trigger …

…a change event)
knockout · Apr 15, 2017 · 61c039f · 61c039f
1 parent 1592bdc
commit 61c039f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/binding/defaultBindings/value.js b/src/binding/defaultBindings/value.js
@@ -76,7 +76,7 @@ ko.bindingHandlers['value'] = {
                 if (newValue === null || newValue === undefined || newValue === "") {
                     element.value = "";
                 } else {
-                    valueUpdateHandler();   // reset the model to match the element
+                    ko.dependencyDetection.ignore(valueUpdateHandler);  // reset the model to match the element
                 }
             }
         } else {
@@ -98,7 +98,7 @@ ko.bindingHandlers['value'] = {
                         if (!allowUnset && newValue !== ko.selectExtensions.readValue(element)) {
                             // If you try to set a model value that can't be represented in an already-populated dropdown, reject that change,
                             // because you're not allowed to have a model value that disagrees with a visible UI selection.
-                            ko.dependencyDetection.ignore(ko.utils.triggerEvent, null, [element, "change"]);
+                            ko.dependencyDetection.ignore(valueUpdateHandler);
                         }
                     } else {
                         ko.selectExtensions.writeValue(element, newValue);