Further fix for #2174: don't re-evaluate on access after we know that…

… no change occurred.
knockout · Mar 6, 2017 · a73cee4 · a73cee4
1 parent d57baad
commit a73cee4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/spec/asyncBehaviors.js b/spec/asyncBehaviors.js
@@ -1147,6 +1147,10 @@ describe('Deferred', function() {
             source({ key: 'value' });
             jasmine.Clock.tick(1);
             expect(countEval).toEqual(1);
+
+            // Reading it again shouldn't cause an update
+            expect(c2()).toEqual(c1());
+            expect(countEval).toEqual(1);
         });
 
         it('Should ignore recursive dirty events', function() {

diff --git a/src/subscribables/dependentObservable.js b/src/subscribables/dependentObservable.js
@@ -348,6 +348,8 @@ var computedFn = {
         this._evalIfChanged = function () {
             if (this[computedState].isStale) {
                 this.evaluateImmediate();
+            } else {
+                this[computedState].isDirty = false;
             }
             return this[computedState].latestValue;
         };